Implement general kinetic model for multi-PLD data #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
commented
Dec 22, 2023
Comment on lines
+1127
to
+1128
| xdata[0, 2] = m0_a_voxel | ||
| xdata[0, 3] = m0_a_voxel |
There was a problem hiding this comment.
I still need to figure out how to get M0b.
tsalo
commented
Dec 22, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 79.62% 79.67% +0.04%
==========================================
Files 37 37
Lines 3946 4004 +58
Branches 551 561 +10
==========================================
+ Hits 3142 3190 +48
- Misses 625 633 +8
- Partials 179 181 +2 ☔ View full report in Codecov by Sentry. |
tsalo
changed the title
Unfortunately, this won't resolve the CBF estimation issues.
tsalo
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272 and closes #298.
Changes proposed in this pull request
Documentation that should be reviewed